[haiku-development] Re: Pairs game
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Wed, 23 Apr 2008 11:33:02 +0200 CEST
Stephan Assmus <superstippi@xxxxxx> wrote:
> I have made a few changes here and there: You got the coding style
> mostly
> right, there was only some issues with inconsistent for loops
> formatting.
> Then you need to make 2 empty lines between methods (again, you did
> it
> mostly right) and always spaces between operators, except ++ and --
> (don't
> know if that last bit is required or not by our guidelines). You had
I would hope so :-)
> virtual private functions in PairsView I think, which was unneeded. I
> also
> formatted the headers of PairsView and PairsWindow a bit differently,
> according to Michael Lotz' proposal, your version was ok, I am just
> proposing this different formatting, maybe you find it better
> readable as
> well. "public" and "private" are not indented, because these are so
> called
> "labels".
Can you point out the differences between your and Michael's proposal?
I somehow can't spot them.
(the only difference I see to how I do it, is that you indent the
variable types in the same way as the method types, where I indent
anything else with just a single tab)
Bye,
Axel.
Other related posts:
