On Thu, Sep 17, 2009 at 14:57, Hervé W. <h_o_w_@xxxxxxxxxxx> wrote: > Hi, > > Tickets 3541 and 4427 are a bit cosmetic in nature. > Instead of specifying Core 2 Extreme for all 45nm Core2's, attached patch > defaults to Core 2. > > > Is further differentiation desired? like showing Extreme or Xeon if > applicable? > my idea would be to add a call to get_cpu_struct() > (found in: headers/private/kernel/cpu.h ) > in get_cpu_model_string() > (in: headers/private/shared/cpu_type.h ) > and searching the arch.model_name field of the result for xeon and extreme > and based on the result: > - add nothing to 'Core 2' (for the Core 2 Duo's and Quad's) > - add ' (Xeon)' > - add ' (Extreme)' > > I could then do the same for the Xeon from ticket 2002 and any other Xeon. > Currently attachments are not allowed on this list and automatically removed. The best course of action is to submit the patch to either of those tickets. When attaching a file, you'll need to add a separate comment to trigger an email notification. ( Attachments alone do not trigger the notification) In general, if a ticket doesn't exist for a patch, creating a new enhancement ticket with [PATCH] in the subject is preferred --mmadia