[haiku-development] Re: [PATCH] mouse modes
- From: Brecht Machiels <brecht@xxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Wed, 22 Apr 2009 15:01:40 +0200
Hi,
Removing the ActivateWindow() wrapper messed things, it seems. Don't
bother to review this patch yet. I would first like to discuss
B_WILL_ACCEPT_FIRST_CLICK (see thread with that title).
Cheers,
Brecht
Brecht Machiels wrote:
Hello again,
I have cleaned up the patch. It can be labeled as 'final' now. You can
find it at http://www.mos6581.org/20090419.diff
Most of the coding style should be fixed now. I have split up the mouse
modes (click-to-activate, click-to-focus and FFM) and the FFM twitcher
modes (normal, warp, instant warp). This breaks backwards-compatibility
for the different FFM modes.
I would like to propose the BitmapView class (which is preliminary) for
inclusion in the API.
As for future a future patch...
I have excluded the hacky wrapper function for Desktop::ActivateWindow()
for now. As far as I can remember, I introduced this to "fix" Tracker
behavior with the new mouse mode. We already had a discussion on how the
Tracker windows behave differently in
//www.freelists.org/post/haiku-development/clickthrough-and-AmigaOS-mouse-mode-patch
While I agree that the drag-and-drop behavior should not be changed, I
believe that a tracker window should not pop to front on clicking inside
it in the FFM and click-to-focus modes. This is inconsistent with the
general behavior of windows in these mouse modes and simple makes no
sense. Can we agree on this? If this can be changed, the interface
should be more consistent and the hack is probably no longer necessary.
In order to behave identically to R5, it is currently not possible to
send a window to back when right-clicking on the resize widget. I would
like to change this so that a window can be sent to back while resizing
it. This would be very convenient in the new click-to-focus mouse mode
(this already works when moving a window). Objections?
Regards,
Brecht
Other related posts:
