[haiku-development] Re: My SetViewUI ... patch

  • From: Adrien Destugues <pulkomandy@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Tue, 6 Oct 2015 07:02:01 +0200

On Mon, Oct 05, 2015 at 03:31:25PM -0500, looncraz wrote:

- Wrong number of blank lines (for example between header and includes,
between methods, etc.). You can't do much wrong by using 2 blank lines
outside of methods (not zero, not three), and one blank line inside
methods.

I found two or three places where this was true - you have a secret to how
you find these so easily?

If you eyes aren't as trained to this as Axel's, you can use one of our
"checkstyle" scripts.

For vim:
https://cgit.haiku-os.org/haiku/plain/3rdparty/pulkomandy/checkstyle.vim
Standalone Python:
https://cgit.haiku-os.org/haiku/plain/src/tools/checkstyle/

They don't detect everything (yet) and they have some false positives,
but they can still be useful.

--
Adrien.

Other related posts: