[haiku-development] Re: Looking for feedback on enhancements for dealing with Mac keyboards with Haiku

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Thu, 13 Oct 2011 01:48:03 -0400

On Fri, Sep 30, 2011 at 4:03 AM, John Scipione <jscipione@xxxxxxxxx> wrote:

> I have uploaded 2 new patches to http://dev.haiku-os.org/ticket/7964. The
> first new patch contains just the HaikuImage changes so you can go look at
> the patch to see if it is okay if you'd like.
>
> The second patch contains just the changes to the Keymap preference app to
> make submenus in the Layout menu work. I added some recursive methods to
> make it work with n levels of subdirectories. Of course this functionality
> isn't really needed now, one level is good enough. But, maybe someday if we
> have a lot of keymap files then organizing them in subdirs could be helpful.
> Besides if you add subdirectories to your user KeyboardLayout dir the app
> won't break. Personally I think this patch is looking really good. The
> recursive methods actually made the code much simpler and cut out a lot of
> repetition as well as getting rid of an ugly goto statement that was a bit
> shaky.
>

Hey, I'd really like to get the patches on the above ticket committed so
that I can create a subdirectory for the ThinkPad Keyboard Layout files that
I added to ticket http://dev.haiku-os.org/ticket/8021. There are 8 of them
so the need for a subdirectory is even more dire than for the Apple Aluminum
layout files.

Thank you,

John Scipione

Other related posts: