[haiku-development] Re: Layout engine
- From: Philippe Saint-Pierre <stpere@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Tue, 7 Apr 2009 14:08:43 -0400
Hi,
2009/4/8 Stephan Aßmus <superstippi@xxxxxx>
>
> On 2009-04-06 at 08:00:18 [+0000], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> wrote:
> > Ryan Leavengood wrote:
> > > rootView (BGroupLayout, horizontal)
> > > - tabView (BGridLayout)
> > > - child controls
> >
> > Looking at Fonts, the BGroupLayout in the root view should better be
> > vertical, I guess (at least the "revert" and "default" buttons are below
> > the tab, not text to it :-)).
>
> In src/tests/kits/interface/look/Look.cpp:318ff, you can see how I do it
> there with a BTabView.
>
> In any case, you can safely assume that things are supposed to be
> intuitive. If something does not work, it's a bug "somewhere". Doesn't
> really matter if it's in your code or in Haiku's, but seeing your code
> which triggers the problem is *always* helpful. :-)
>
> Best regards,
> -Stephan
>
Okay, I tried to figure out the error (I'm quite sure it's a mistake on my
side, as usual) but I can't find out. Maybe someone with expert eyes could
help me..
After posting, I found a few style coding error, sorry about that, I will
review it before posting a patch..
Here are what I think are the revelent parts :
http://pastebin.com/m3af08e5
If you think something is missing, I will post the whole thing..
So, the buttons (defaults, revert) appear below the tab, it doesn't crash
nor display debug message at command line, but the menu fields don't appear
in the tab view.
Thanks a bunch!!!
Philippe 'stpere' St-Pierre
Other related posts:
