[haiku-development] Re: ICMP fix
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Tue, 17 Jun 2008 18:45:59 +0200 CEST
Hi Jan,
Jan Kloetzke <jan.kloetzke@xxxxxxxxxx> wrote:
> here's a small fix for the ICMP module. Currently it will reply to *
> every*
> ping requests while a interface is _not_configured_ yet. This
> prevents Haiku
> from getting a DHCP address in VMware server because the DHCP server
> will
> test (via ping) if the offered address is already in use. As Haiku
> (incorrectly) replies to the ping the DHCP server will think the
> address is
> already used.
Great, thanks! I've applied it in r25995.
> The attached fix adds a check that the destination address of the
> incoming
> packet is equal to the address of the incoming interface. The ping is
> only
> replied if both addresses match.
>
> There is one regression: we will not reply to broadcast pings
> anymore. But as
> far as I know nearly everybody has this disabled by default anyhow...
That's definitely acceptable.
Bye,
Axel.
Other related posts:
