[haiku-development] Re: I want to involve
- From: "François Revol" <revol@xxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 06 Mar 2008 14:18:00 +0100 CET
> "Lukas Durfina" <lukas.durfina@xxxxxxxxx> wrote:
> > I want to involve in Haiku development,
> > so I tried to make patch, which clears code
>
> There are several problems of that patch:
> 1) We only use tabs not spaces for indenting
> 2) I think your somewhat aggressive use of static_cast makes things a
> bit unreadable, as in:
> - kDefaultShellCommand[1], NULL);
> + kDefaultShellCommand[1], static_cast<char
> *>(NULL));
> 3) if you need to break a line into two, the second line is only
> indented a single tab, so the following (as you did) is wrong:
> - return CurPos(p.x / fFontWidth, p.y / fFontHeight);
> + return CurPos(static_cast<int32>(p.x / fFontWidth),
> + static_cast<int32>(p.y / fFontHeight));
Btw,
On ffmpeg accepted patches must submitted separately for real and
cosmetic (indentation) changes.
We don't need to be strict about that but it helps finding the real
changes.
François.
Other related posts:
