[haiku-development] Re: How to increase files limit?

  • From: Andreas Färber <andreas.faerber@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sat, 24 Apr 2010 18:16:52 +0200

Falscher Thread!?

Gruß,
Andreas

Am 24.04.2010 um 17:41 schrieb Ingo Weinhold:

Forgot my comments regarding the patch:

Index: build/jam/ImageRules
===================================================================
--- build/jam/ImageRules        (revision 36442)
+++ build/jam/ImageRules        (working copy)
@@ -605,6 +607,17 @@
[...]
+                       local isGCCAgnostic = [ on $(archiveFile)
+                               return $(ARCHIVE_IS_GCC_AGNOSTIC) ] ;
+                       # NOTE: passing "true" thru init script causes the 
variable to be
+                       # resolved as a build system file, eg
+                       # objects/haiku/x86/release/bin/coreutils/src/true

The reason for this is that parameters to actions should only be targets (they are treated as such by jam), not any other kind of parameters. I see that is already incorrect for $(extractedSubDir). Non-target parameters should be passed via on-target variables (on the generated target). E.g. in
this case:

ARCHIVE_IS_GCC_AGNOSTIC on $(dummyTarget) = $(isGCCAgnostic:E=false) ;


Index: build/scripts/build_haiku_image
===================================================================
--- build/scripts/build_haiku_image     (revision 36442)
+++ build/scripts/build_haiku_image     (working copy)
[...]
+createSymlinksForHybrid()
+{
+       echo 'createSymlinksForHybrid ...'
+       for srcPathLib in $@; do
+               aLib=`echo $srcPathLib | sed -e "s:.*/::"`

basename

+               destLinkTarget="../$aLib"
+               srcPath=`echo $srcPathLib | sed -e "s:${aLib}::"`

dirname

+               destLinkDir="${srcPath}${gccAltDir}"                  
+               mkdir -p $destLinkDir
+               ln -sf -t $destLinkDir $destLinkTarget
+       done
+}

Other than that (and the debug code and the 80 column limit) the changes look
OK.

CU, Ingo



Other related posts: