I pushed the changes to a clean request.
https://review.haiku-os.org/#/c/164/
I was not able to replay each commit due to the merge commits. So I pushed
everything in one commit.
Regards
Hrishikesh
On Fri, May 4, 2018 at 7:10 PM Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
wrote:
4 mai 2018 15:08 "Hrishi Hiraskar" <hrishihiraskar@xxxxxxxxx> a écrit:
Okay. I understood the working of gerrit.with current situation?
Now should I abandon and reupload the changes? Or no need if you're okay
We will only merge things with a clean git history. So you should cleanup
your history and then
submit things cleanly split, so that each commit is independant and easily
reviewed. Moreover,
there should not be merge commits (usually I set up git with "autorebase"
to avoid them) as we
try to keep the history of the main repo linear and easy to read.
--
Adrien.
