Was building haiku.hpkg and ran into the build problem listed below.
The problem is this method, you have to decide if the return var is an
int or an int32, the compiler seems to be a bit picky about the type.
static int nvme_interrupt_handler(void* _info)
Also there are some 80-char limit violations on lines 293 and 297 of
nvme_disk.cpp
SetVersion1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/power/cpufreq/intel_pstates/intel_pstates
Chmod1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/power/cpufreq/intel_pstates/intel_pstates
Link generated/objects/haiku/x86_gcc2/release/add-ons/kernel/cpu/x86/generic_x86
SetVersion1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/power/cpuidle/intel_cstates/intel_cstates
AppendToContainerCopyFilesScript
<hpkg_-haiku.hpkg>haiku.package-copy-files-dummy-add-ons/kernel/power/cpufreq
In file included from
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_internal.h:46,
from
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:25:
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/compat/nvme_platform.h:15:
warning: `PTHREAD_MUTEX_INITIALIZER' redefined
/boot/home/Projects/Haiku/haiku/headers/posix/pthread.h:78: warning:
this is the location of the previous definition
Chmod1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/power/cpuidle/intel_cstates/intel_cstates
C++
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/drivers/disk/nvme/libnvme_haiku.o
AppendToContainerCopyFilesScript
<hpkg_-haiku.hpkg>haiku.package-copy-files-dummy-add-ons/kernel/power/cpuidle
Cc
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/drivers/disk/nvme/nvme.o
SetType1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/cpu/x86/generic_x86
MimeSet1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/cpu/x86/generic_x86
Cc
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/drivers/disk/nvme/nvme_admin.o
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:
In function `status_t nvme_disk_init_device(void *, void **)':
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:293:
passing `int (*)(void *)' as argument 2 of
`install_io_interrupt_handler(long int, int32 (*)(void *), void *,
long unsigned int)'
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:
In function `void nvme_disk_uninit_device(void *)':
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:313:
passing `int (*)(void *)' as argument 2 of
`remove_io_interrupt_handler(long int, int32 (*)(void *), void *)'
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:
In function `status_t nvme_disk_close(void *)':
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp:347:
warning: unused variable `struct nvme_disk_handle * handle'
Cc
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/drivers/disk/nvme/nvme_common.o
gcc -c "src/add-ons/kernel/drivers/disk/nvme/nvme_disk.cpp" -O2 -Wall
-Wno-multichar -Wpointer-arith -Wsign-compare -Wno-ctor-dtor-privacy
-Woverloaded-virtual -march=pentium -nostdinc -finline -fno-builtin
-fno-exceptions -march=pentium -D_KERNEL_MODE -DARCH_x86
-D_BEOS_R5_COMPATIBLE_ -DBOOT_ARCHIVE_IMAGE_OFFSET=320
-D__HAIKU_PRIMARY_PACKAGING_ARCH=\"x86_gcc2\"
-DHAIKU_DISTRO_COMPATIBILITY_DEFAULT -DHAIKU_TARGET_PLATFORM_HAIKU
-DHAIKU_REGULAR_BUILD -Ibuild/user_config_headers
-Ibuild/config_headers -Isrc/add-ons/kernel/drivers/disk/nvme
-Igenerated/objects/common/add-ons/kernel/drivers/disk/nvme
-Igenerated/objects/haiku_host/x86_gcc2/common/add-ons/kernel/drivers/disk/nvme
-Igenerated/objects/haiku/x86_gcc2/common/add-ons/kernel/drivers/disk/nvme
-Isrc/add-ons/kernel/drivers/disk/nvme/libnvme
-Isrc/add-ons/kernel/drivers/disk/nvme/compat
-Isrc/system/kernel/device_manager -I- -Iheaders/private/.
-Iheaders/private/kernel -Iheaders/private/libroot
-Iheaders/private/shared
-Iheaders/private/kernel/boot/platform/bios_ia32
-Iheaders/private/kernel/arch/x86
-Igenerated/objects/haiku/x86_gcc2/common/system/kernel
-Iheaders/private/. -Iheaders/private/system
-Iheaders/private/system/arch/x86 -Iheaders/compatibility/bsd
-Isrc/add-ons/kernel/drivers/disk/nvme -Iheaders/cpp -Iheaders/glibc
-Iheaders/posix -Iheaders/build/gcc-2.95.3 -Iheaders -Iheaders/os
-Iheaders/os/add-ons -Iheaders/os/add-ons/file_system
-Iheaders/os/add-ons/graphics -Iheaders/os/add-ons/input_server
-Iheaders/os/add-ons/registrar -Iheaders/os/add-ons/screen_saver
-Iheaders/os/add-ons/tracker -Iheaders/os/app -Iheaders/os/device
-Iheaders/os/drivers -Iheaders/os/game -Iheaders/os/interface
-Iheaders/os/kernel -Iheaders/os/locale -Iheaders/os/media
-Iheaders/os/mail -Iheaders/os/midi -Iheaders/os/midi2
-Iheaders/os/net -Iheaders/os/storage -Iheaders/os/support
-Iheaders/os/translation -Iheaders/private/. -o
"generated/objects/haiku/x86_gcc2/release/add-ons/kernel/drivers/disk/nvme/nvme_disk.o"
...failed C++
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/drivers/disk/nvme/nvme_disk.o
...
/boot/home/Projects/Haiku/haiku/src/add-ons/kernel/drivers/disk/nvme/libnvme/nvme_common.c:283:
warning: no previous prototype for `nvme_lib_exit'
SetVersion1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/cpu/x86/generic_x86
Chmod1
generated/objects/haiku/x86_gcc2/release/add-ons/kernel/cpu/x86/generic_x86
AppendToContainerCopyFilesScript
<hpkg_-haiku.hpkg>haiku.package-copy-files-dummy-add-ons/kernel/cpu
