[haiku-development] Re: [Haiku-commits] r21394 - in haiku/trunk: headers/os/interface src/kits/interface

  • From: "Jonas Sundström" <jonas@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 13 Jun 2007 18:05:13 +0200 CEST

Looking at the results I think we're fooling ourselves, 
optimizing for the most unlikely case, so to speak:
the -combination- of a shortcut -and- a submenu indicator.

http://www.kirilla.com/tmp/new_menuitem_layout/

I don't think it looks good. We're forcing two separate columns in -
lots- of menus, where the simple items using either a shortcut -or- a 
submenu indicator would look much better aligned vertically, roughly 
the way they are in BeOS:
http://www.kirilla.com/tmp/new_menuitem_layout/r5.png
http://www.kirilla.com/tmp/new_menuitem_layout/fake_similar_to_r5.png
(Not exactly pixel perfect. I used drag&drop in ShowImage.)

I suggest that this layout behavior is kept:
http://www.kirilla.com/tmp/new_menuitem_layout/keep/

And that this behavior is changed to single column:
http://www.kirilla.com/tmp/new_menuitem_layout/fix/

In short, no space* on the right hand side unless there's a
Command shortcut -combined- with a submenu indicator, 
in which case all submenu indicators are pushed to the
right side border. Like this:
http://www.kirilla.com/tmp/new_menuitem_layout/keep/screen06.png
else, they are aligned, like this:
http://www.kirilla.com/tmp/new_menuitem_layout/fake_similar_to_r5.png

* The alignment is what I'm after, not necessarily the removal of 
space.

/Jonas.


Other related posts: