[haiku-development] Re: [GSOC] xhci or USB3.0 support initial patch

  • From: "Michael Lotz" <mmlr@xxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 30 Mar 2011 23:16:47 +0200

> 2011/3/30 Jian Chiang <j.jian.chiang@xxxxxxxxx>:
> >> Thanks for the patch! It seems the advice to look at the existing 
> > > USB
> >> module add-ons was most fruitful. :-)
> >
> > Yep. Absolutely. I borrowed code from EHCI driver.
> I committed the patch with style fixes in r41142. This was easily
> explained by the fact that the EHCI driver isn't in line with our
> coding style guide.

Since this is mostly my code, I'd like to point out that for example 
for the asterisk style we've had the stance (and I think we still have) 
that it's preferred to have it consistent within the component, so I'd 
hate to see that one changed for XHCI while the rest of the USB code 
has the other. Not that you did that in your commit, just wanted to 
clarify that I originally started with that style and kept it for all 
my USB work. Same with most other "style issues" which were simply 
different back then with new rules established since (it's basically 
the OpenTracker style, because that's where I was originally coming 

In general I was in my natural "damn, but I wanted to do XHCI..." stance 
when I first saw this thread come up, but since have given up on that 
because I simply do not realistically have the time to do any real work 
there and obviously don't want to (and really can't anyway) stand in 
the way of progress. I see that you (addressing Jian Chiang) have taken 
the time to look into the existing codebase and have done the changes 
pretty much in line of how I originally intended it to work so far, 
which makes me quite happy. If your project is picked for GSoC I'd like 
to try and be available for questions that might arise, but I'm really 
quite constrained time wise. In any case, good work so far and keep it 


Other related posts: