[haiku-development] Fwd: Change in haiku[r1beta2]: app_server: fix crash caused by missing locking

  • From: Niels Sascha Reedijk <niels.reedijk@xxxxxxxxx>
  • To: Haiku Development <haiku-development@xxxxxxxxxxxxx>
  • Date: Fri, 12 Jun 2020 07:48:11 +0100

Hi,

Why are we still doing changes against the r1beta2 branch after the
release has been cut? (See below)

N>

On Thu, Jun 11, 2020 at 7:24 PM Gerrit <review@xxxxxxxxxxxxxxxxxxx> wrote:


waddlesplash submitted this change.

View Change

Approvals: waddlesplash: Looks good to me, approved

app_server: fix crash caused by missing locking

Change-Id: Ib9b0c2282f947c0c6ac61fc3e97f9eca7af8dda4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2891
Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>
Reviewed-by: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
(cherry picked from commit 638f8647a6887f649f5e31e0177c8c9ac4225a46)
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2904
---
M src/servers/app/ServerApp.cpp
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/src/servers/app/ServerApp.cpp b/src/servers/app/ServerApp.cpp
index e2092f6..6250f11 100644
--- a/src/servers/app/ServerApp.cpp
+++ b/src/servers/app/ServerApp.cpp
@@ -922,6 +922,7 @@
  int32 token = -1;
  link.Read<int32>(&token);

+ BAutolock _(fMapLocker);
  if (ServerPicture* subPicture = _FindPicture(token))
  picture->NestPicture(subPicture);
  }

To view, visit change 2904. To unsubscribe, or for help writing mail filters, 
visit settings.

Gerrit-Project: haiku
Gerrit-Branch: r1beta2
Gerrit-Change-Id: Ib9b0c2282f947c0c6ac61fc3e97f9eca7af8dda4
Gerrit-Change-Number: 2904
Gerrit-PatchSet: 2
Gerrit-Owner: waddlesplash <waddlesplash@xxxxxxxxx>
Gerrit-Reviewer: X512 <danger_mail@xxxxxxx>
Gerrit-Reviewer: waddlesplash <waddlesplash@xxxxxxxxx>
Gerrit-MessageType: merged

Other related posts: