[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 29 Nov 2015 11:08:42 -0600

On 11/29/2015 10:49, looncraz wrote:

On 11/29/2015 10:18, Dario Casalinuovo wrote:

https://gist.github.com/Barrett17/4d5543b35fa3056a8429


Okay, so it actually seems you caught a few things others didn't mention, along with some previously repair duplicates ;-)

"9790 : why hardcoded string? It seems not locale aware too, anyway."

The issue here is that the string width may no longer be the longest in a different language, and without running StringWidth on each label and using the maximum size there really is not a proper way to do this. I just used that string because it is the longest in every language I know ;-)

___________________________
"9852 : tab before comment to be removed"

Not according the style guidelines:

if(someCondition){
DoSomething();
// Comments that only affect a single line are usually
// written after it, and are indented by a single tab

________________________

"19543 : all is public? why?"

The data members are directly accessed by DelayedMessage and ScheduledMessage. I debated changing the data member names to use a struct-like naming convention, or even using struct. I'm not against changing this in any way if you think that would make more sense.

I have made all of the other changes you mentioned, I will update the patch and diff.

--The loon


Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 11-2015