[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 29 Nov 2015 10:49:38 -0600

On 11/29/2015 10:18, Dario Casalinuovo wrote:

Besides the technical things that others pointed out, which is a subject where I can't say nothing, other code looks like OK for me, except some minor problems. I've created a gist where I'm listing what I've seen :

https://gist.github.com/Barrett17/4d5543b35fa3056a8429

If you're going to be pointing out style issues in anything but the applications, you should use the diff, most of what you found has been repaired previously. I will look through all the ones you mentioned, though, because I'm sure you caught something others have missed.

I'm afraid that big^2 patches like this aren't the best way to get in touch. It was better if we could review a few little patches from you, and then at some point if you want it, you could ask for commit access.

This patch really can't be split up and remain a coherent change, sadly. It has been discussed and it seems my current breakdown is acceptable (I rewrote most of the history, but there are some corrective commissions at the tail).

Note also that for most fixes (especially when you don't need a newline) you can do it directly in the patch by editing those specific lines (i.e. add a tab or remove it, fix a typo). This makes the process more faster and less annoying.

This. I did not know. I've meant to ask 1,000 times if I could make simple corrections like that (such as for the commit message) or the offsets were byte-wise or line-wise. I haven't spent anywhere near enough time examining the patch format. Thanks!

--The loon


Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 11-2015