> On Sat, Sep 1, 2012 at 5:40 PM, Fredrik Modèen <fredrik@xxxxxxxxx> wrote: >> >> Now I have extend the BMessage with Save essage stuff from showimage. >> This >> are how it would look like. Sorry for posting this here and not on track >> but I think it's easier to comment things here :). > > Actually Trac may be better since it makes the patches easier to read. OK.. >> What I would like to know are. >> Are this good enough to be commitded :) >> >> This have not been tested more that I can build it.. > > It looks pretty good, but since I was not involved as much in the > discussion, I'll wait for more people to respond before trying to > commit it. NP, I'll wait little longer :) >> git diff any got me the diff for existing files, the one I added with >> git >> add [file] was not showd with diff.. > > For your future knowledge you can get a diff with all changes, > including added files, by adding them all the git (as if you were > going to commit) and then using git diff --cached to see those > changes. This will show the added files too. That was relay good to know.. (going to my txt doc about good git comande to know) >> The SaveMessage class was added to storage kit. > > I think that is what everyone thought made sense. Yes I know. :) I have sins then tested to implement it in showimage (not run tested it yet) I then dicover that I needed some more Get methods, not anything fancy. -- MVH Fredrik Modèen