[haiku-development] Re: Coding Style clarification/vote

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Mon, 29 Jun 2009 21:24:44 +0200

On 2009-06-29 at 20:13:40 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> 
wrote:
> Stephan Assmus <superstippi@xxxxxx> wrote:
> > On 2009-06-29 at 19:42:58 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> > > wrote:
> > > 1) After the license header (and eventual header guard), should
> > > there
> > > be one or two blank lines between the contents? I prefer two as that's
> > > what we use everywhere else to separate sections, but most seem to 
> > > prefer
> > > a single blank line.
> [...]
> > > As a short overview my votes are:
> > > 1) 2
> > > 2) b
> > My votes would be the same. As an addition, I would like to propose to 
> > get
> > rid of the distinction between copyright in the header and copyright in 
> > the
> > implementation. IIRC, it's currently no blank line between copyright and
> > header guard but one blank line between copyright and includes in source
> > files. This is just arbitrary nonsense that I didn't even remember which
> > way around for the longest time. I'd vote to make it one blank line 
> > after
> > the copyright regardless of where the copyright is.
> 
> You must have misunderstood me; at least, you just voted for two blank 
> lines after the copyright.
> Despite that, I would be against this change, and see the copyright and 
> header guard as one union (= the necessary evil).

To be honest, I don't care so much about how many blank lines are used to 
separate stuff at the top of files. As I said I find it awkward to remember 
that there is sometimes no blank line after the copyright and sometimes 
there is one. What you consider the "necessary evil" and therefore a single 
block does not serve really well as something obvious and easy to remember. 
On the contrary, I would think that a consistent "one blank line after the 
copyright" or "no blank line after the copyright" is easy to remember. In 
any case, I care more about other aspects of the coding style guide.

So I am voting:

1) No vote
2) b

Best regards,
-Stephan

Other related posts: