[haiku-development] Re: Change patches workflow [was Final Set*UIColor Patch, Version 3e]

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 29 Nov 2015 19:54:41 -0600

On 11/29/2015 18:03, Dario Casalinuovo wrote:


There is a difficult constraint here that

we don't want too much people doing admin work on the servers, yet
it is
not reasonable to expect just one person to handle everything. We have
to find the right balance.


Not that I want to criticize, really, I'm just under the impression that this is the locking part of the Haiku project. This affects so many things that are vital to the project...I don't expect miracles, but on the long run a solution should be found. If we don't have the force to deploy an automatized tool, then the only remaining thing is to go for the manual way.

Well, if you want a workflow, it should be, for feature patches at least, IMHO, something like the following:

1. Submit a proposal through the dev mailing list / BugTracker
2. Await community feedback re worthiness and implementation basics
3. Initial patches should be review incrementally for implementation of design
4. A vote is held to assign responsible reviewer(s), volunteers welcome
5. Submission candidate patches are reviewed for bugs, design issues
6. Bugs are fixed, reworkings made
7. Patches are reviewed for style violations and cleanup
8. Style violations are repaired exclusively by originating author(s).
9. Final review
10. Commit to experimental branch
11. Experimental branch patches moved to master after community testing

Style fixes are nearly LAST, but glaring issues are pointed out when noticed, which will help eliminate the duplication of effort and submitter frustration.

At least that's my thinking ;-)

--The loon

P.S. I haven't forgotten about expanding my style checker and sharing it, its current design is actually quite a bit more flexible than the existing tools in some regards - especially since it can parse diffs or patch files directly. In fact, it dawned on me a few days ago that a text-parsing system I've used somewhat frequently (written in PHP) may make a nice foundation for a really nice online style checker. I already requested permission to use it (it's very much closed source), no word back yet, but I don't think it will be a problem.

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 11-2015