Ok, I'm plotting to do something that could have dire consequences if I miss something :)
Looking at Accelerant.h... it has quite a bit in it that seemingly doesn't need to be public
(mostly the "opcodes" and accelerant hook functions)I'm thinking of taking the opcodes and accelerant hook functions and placing them
in two private headers.I *just* don't see any use case of userspace stuff needing access to these opcodes (unless someone is developing an out-of-tree video accelerant + driver... in that case they can have their own AccelerantAPI*.h until they get their changes in-tree)
I found the diff's not explaining this well... I pastebin'ed the new files
Was: - headers/os/add-ons/graphics/Accelerant.hhttp://cgit.haiku-os.org/haiku/tree/headers/os/add-ons/graphics/Accelerant.h
Will be: - headers/os/add-ons/graphics/Accelerant.h http://pastebin.com/e2zWJNZr - headers/private/graphics/common/AccelerantAPI1.h http://pastebin.com/8P3KyE1R - headers/private/graphics/common/AccelerantAPI2.h **Not done yet ;)** Thoughts? -- Alex