[haiku-development] Re: BFlattenable BStringList? Was: Re: [haiku] Fetching mail via pop3 from GMail

  • From: clemens.zeidler@xxxxxxxxxxxxxx
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 14 Dec 2011 14:17:16 +1300

> So, long story short, the API can still be freely modified. I suppose 
> making BStringList BFlattenable is fine (the B_STRING_LIST_TYPE should 
be added to <TypeConstants.h> accordingly).
> 
> Looking at the mail daemon BStringList, I'd be very much against 
> copying some of the API verbatim. NotHere() and NotThere() are horrible 
method names and, like the operators that perform a set operation, 
might seem convenient in certain cases, but are definitely slow by 
design. I'd either omit them completely or only add them as methods 
with suitable names and an explicit warning.
> 
> CU, Ingo
> 

Same thoughts here, the only method I like to add is:

void    Remove(const BStringList& list, bool ignoreCase = false);

(plus the flatten methods)

are there already some helpers to flatten a BString? strings are scaring 
me ;) or any tricks to flatten the BStringList? as Ingo already said, 
the way the public list is storing strings is quite different (but more 
elegant and efficient) from the mail version.

thanks,
        Clemens




Other related posts: