On Sun, Jul 22, 2018 at 3:15 AM, Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
wrote:
BScrollBar has its own _ButtonFor code, but in the current state this
would not work with a replacement BControlLook with different button
sizes (or no buttons at all, or…). The code in _ButtonFor would get out
of sync with the one in BControlLook.
We have two options here:
- Either revert to separate DrawButtons and DrawBackground methods, and
let BScrollBar manage the layout. In this case, BControlLook cannot
change the button layout of the scrollbar
- Or, let BControlLook tell BScrollBar where the buttons should be
placed.
Sorry for the late comments, I had no time to review the BControlLook
version of https://review.haiku-os.org/#/c/haiku/+/300/ which spent just
6 hours on review before being +2 and merged by the same person (I would
prefer we avoid that, unless there is an emergency).