[haiku-development] Re: B_VIEW_RESIZED fields type

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Mon, 02 Aug 2010 00:52:59 +0200

On 2010-08-01 at 17:14:43 [+0200], François Revol <revol@xxxxxxx> wrote:
> It seems we violate the BeBook on B_VIEW_RESIZED:
> http://www.haiku-os.org/legacy-docs/bebook/TheInterfaceKit_MessageConstants.html#B_VIEW_RESIZED
> 
> We should use int32 type but the code uses floats.
> This breaks the XEmacs port at least.
> Seems nobody noticed because BView::FrameResized() doesn't use the fields 
> directly.
> 
> Does anyone use them as float already or can I fix them ?

Please fix. You can grep the code to see if any app in the repository extracts 
the fields, but I 
doubt it.

> Maybe we could add a rect field as well, which does use floats...

Nah... wouldn't be so useful and just adds overhead.

Best regards,
-Stephan

Other related posts: