On 2010-04-23 at 15:11:49 [+0200], Matt Madia <mattmadia@xxxxxxxxx> wrote: > While feeling sort of proud at the whopping commit of r36419, I wanted > to try #5481 -- providing a mechanism for the user to opt-in on which > source archives to install (eg from the CD). Basically, the > functionality of the expandable "> Show optional packages" view was > being duplicated. > > The patch is at a point where it appears to be visually functional. > eg, running it from <generated>. Though, I can't get it to display > items in <source volume>/_packages_/ or <source volume>/_sources_/ > Is it simply a matter of dropping the archives in the respective > directories or ...? I've looked over the patch, but I don't like duplicate functionality. Why not simply display the source archive packages along software packages? Then you can remove all the changes from WorkerThread and CopyEngine and also most changes to the window. In the packages list view, perhaps there could be a visual separation of source packages versus binary packages, but I think two separate lists are not elegant. Best regards, -Stephan