Hi, Am 17.12.2013 01:33, schrieb Jonathan Schleifer:
After that, tqh promised to not forget about the branch and working on getting it in.
Ok. But are we talking about a general problem with the project now, or are we talking about a single Haiku developer not following up on his promise he dropped in IRC? And what did he promise, to get your patches in, or to try and make some time to look at them? Because, I usually promise only the latter, if anything at all.
Of course I am not saying that getting patches into Haiku is /not/ often frustrating and there is no general problem. I stand by my opinion, though, that the problem is simply too few developers with to little spare time.
So, as you can see, there is a real problem that can't be reduced to "I rather code than look at Trac".
I don't think we are on the same page yet, what we think the problem is. When I had enough time to work on the project, I would do all sorts of stuff, writing my own code, communicating, looking at bugs and of course at patches. IIRC, you are still young. You probably study at a university somewhere. You probably have no idea how it is once you have a family and kids. I am taking time to write this right now while I should be working, and I already feel bad about that. And the problem is that most Haiku devs *these days* are in a similar situation.
I'm just pointing the problems I experienced so that the workflow can be improved.
Ok, but how can it be improved? Do you mean that everything would be fine, if people would just follow up on their promises?
If you are still interested, maybe it would be a good idea for people who actually reviewed your patches to speak up whether they feel you should simply get commit access. It would definitely be great to have you.Yes, I did not lose interest in Haiku, I only became frustrated with not getting it in and basically gave up. Commit access would solve that problem and I'd be more than happy to commit these changes myself, but unfortunately this only solves the problem for me, not for others. So while this would be a solution with which I'd be very happy, the workflow would still need improvement. I remember than when I looked through Trac more than 1 year ago, there were many interesting patches which just rotted there.
No. Giving you commit access adds you to the pool of developers who spend time now and then to review other peoples patches. So actually it would improve the situation. We just need more of you.
At the same time, most Haiku devs are hesitant to grand access. It is very hard (emotional, bad vibes) to revoke access later on. Only those people should get it where devs feel they would not degrade the code base over time. My impression from meeting you at BG is that you would not, and mostly know what you are doing. But I haven't looked at your patches and its not even my usual field of expertise.
At least that's why we are still talking and you don't have access already... hope you understand.
Best regards, -Stephan
