Am 15.12.2013 17:14, schrieb Jonathan Schleifer:
Am 14.12.2013 um 13:20 schrieb Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>:I do hear some frustrationSorry, but I can only agree here.
I'm sure everyone understands the frustration. They are probably frustrated themselves for how things are.
When I was at last year's BeGeistert, it was easy to get changes in, as there were enough people to bug IRL to commit it. However, once I was home, I had a hard time getting something in.
Maybe that's because when people are at home, they suddenly have very little spare time. When they are at BeGeistert, they practically carved out some Haiku time for them. I for one didn't even manage that much for the last BeGeistert.
This is also true for the clang branch: I submitted several small changes which were reviewed and I got a lot of feedback that I incorporated. After I fixed everything that was criticized, there was no feedback anymore. I then rebased it after a few months and converted it to one medium-sized patch (I really wouldn't call it big), so that I can properly document it (if you look at the full commit message, you can see it's quite long and contains a detailed explanation about how to use it). I didn't want to create a new text file describing all that which is going to change, so I decided to have it in the commit message. Also, splitting it into many commits that just change 2 lines seemed wrong, as then there would have been no way to group these commits. However, for almost a year, nothing happened then and I moved on to other things. The patch finally fulfilled all requirements that were given to me on the mailing list, yet nothing happened, so I didn't pursue it any further. I deemed that as lack of interest and moved on to other projects. But even for small patches, it was extremely hard for me to get them in, which is one of the main reasons I lost interest. Even for such small things as fixing the rendering of bold text in the terminal so an m actually looks like a letter and not like a blob.
Understandably. I can tell you that nobody likes being a roadblock to anybody else. Suppose you find yourself with an hour of spare time all of the sudden. Do you, a) spend it figuring out which patch you should look at first on Trac or b) picking up where you left off coding Haiku and finally trying the idea you had rolling in your head for a while? Sometimes I do a), but then I find out the code is not good quality and I have to chose to either explain to the contributor what I would do differently or just do the work myself. But when I want to apply the patch, it no longer applies...
The real problem here is that there simply isn't a critical mass of Haiku committers with enough spare time to also work through patches, among other things.
If you are still interested, maybe it would be a good idea for people who actually reviewed your patches to speak up whether they feel you should simply get commit access. It would definitely be great to have you.
Best regards, -Stephan