"Clemens Zeidler" <clemens.zeidler@xxxxxxxxxxxxxx> wrote:
So coding style (for example ***)) vs maintainability? I prefer the
second
in this case.
It's not just about coding style, it's also about usability,
compatibility, and clobbering the global name space (which our current
ACPI.h does as well, though).
In order to ensure backwards compatibility, it's a good idea not to use
upstream things that you don't control directly in a public header.
However, why not keep the rest of the file private, and do not export
it in ACPI.h, ie. only add the functions to the module? As long as it's
only used internally, there is nothing wrong in using them directly.
