[haiku-commits] Re: r43031 - haiku/trunk/src/preferences/time

  • From: "Adrien Destugues" <pulkomandy@xxxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 31 Oct 2011 17:22:02 +0100

Ryan Leavengood <leavengood@xxxxxxxxx> a écrit :
> On Mon, Oct 31, 2011 at 9:25 AM,  <pulkomandy@xxxxxxxxxxxxxxxxx>
> wrote:
> >
> >  * Move the GMT/Local radio box to the timezone tab
>
> I'll need to see how it looks, but this may indeed be the better way
> to fix the time preview issue I just worked on.
>
> Also with this the _NotifyClockSettingChanged() method and associated
> messaging logic is superfluous and messy. Since the radio buttons now
> reside in the same view as the time zone preview, you can just show
> and hide the previews directly based on the setting. I only did the
> messaging because they were in different views before.

I'm not too confident on what I'm doing there. I think the message end
up going to the other view, where it hasno use anymore. Will have
another look at cleaning that. I understand the timezones previews
should be hidden when clock is set to local time. The timezone must
still be selected in order to handle DST switches. Is that right ?

>
> >  * Remove the huge and unclear tooltip that explained it before
> > (that'd rather
> > be part of the userguide)
>
> I don't know if it was that unclear, it's a complicated topic. Are
> you
> going to add it or something similar to the User Guide? If not I
> could
> add that to my TODO list. I could probably explain it more clearly
> within the user guide than within a tooltip.

Well, the tooltip was pretty big and such information just doesn't fit
in a tooltip. Feel free to improve the userguide text, I'm not looking
at it right now (but could add it to my TODOs as well).

--
Adrien.

Other related posts: