[haiku-commits] Re: r43024 - haiku/trunk/src/servers/app/drawing

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 31 Oct 2011 11:46:07 +0100

Hi,

On 31.10.2011 11:04, mmlr@xxxxxxxx wrote:
Modified: haiku/trunk/src/servers/app/drawing/ViewHWInterface.cpp
===================================================================
--- haiku/trunk/src/servers/app/drawing/ViewHWInterface.cpp     2011-10-31 
09:56:00 UTC (rev 43023)
+++ haiku/trunk/src/servers/app/drawing/ViewHWInterface.cpp     2011-10-31 
10:04:32 UTC (rev 43024)
@@ -420,7 +420,6 @@

        be_app->Lock();
        be_app->Quit();
-       delete be_app;
  }

I remember having the same change in one of my local trees. However, I wonder why Quit() deletes the be_app. The BeBook advertises this code (or similar) for main():

MyApp* app = new MyApp();
app->Run();
delete app;

I usually have this:

MyApp app;
app.Run();

Both should free app. So why is it incorrect for the test environment?

Best regards,
-Stephan



Other related posts: