[haiku-commits] Re: r42857 - in haiku/trunk: headers/private/graphics/intel_extreme src/add-ons/accelerants/intel_extreme src/add-ons/kernel/drivers/graphics/intel_extreme

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 16 Oct 2011 10:38:41 +0200

On 10/15/2011 05:35 PM, mmlr@xxxxxxxx wrote:
  extern char* gDeviceNames[];
  extern intel_info* gDeviceInfo[];
  extern pci_module_info* gPCI;
[...]
+static inline uint16
+read16(intel_info&info, uint32 encodedRegister)
+{
+       return *(volatile uint16 *)(info.registers
+               + 
info.shared_info->register_blocks[REGISTER_BLOCK(encodedRegister)]
+               + REGISTER_REGISTER(encodedRegister));

Nice changes (I guess the 'A' can go away as well that denotes the display?), but could you follow the asterisk style used in the file? ;-)

Bye,
   Axel.

Other related posts: