[haiku-commits] Re: r42725 - in haiku/trunk/src/add-ons/kernel/generic: ata_adapter ide_adapter

  • From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Thu, 08 Sep 2011 13:42:09 -0500

On Thu, 08 Sep 2011 13:28:01 -0500, Alexander von Gluck wrote:

On Thu, 08 Sep 2011 20:11:07 +0200, Axel Dörfler wrote:

On 08.09.2011 17:47, kallisti5@xxxxxxxxxxx wrote:

* gcc2 build now fixed after r42724


Are you sure? It looks like you actually broke ide_adapter as you
obviously renamed all occurrences of ide_channel to ideChannel which
also happens to be a field name.
Always compile before you commit!


The original breakage was because I compiled in gcc4 and not gcc2
before committing.


This was all due to gcc2 C89 vs C99.

Once i moved from .c to .cpp to fix sprintf
(https://dev.haiku-os.org/changeset/42725) I had several errors about
changing from signed to unsigned types.
I also was receiving errors because of the matching type and variable names.
I made changes to the effected files, but forgot to commit the header changes. 

As of r42726, everything should be functioning.

Thanks!
 -- Alex

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 09-2011