[haiku-commits] Re: r42566 - haiku/trunk/src/add-ons/kernel/drivers/graphics/radeon_hd

  • From: Philippe Houdoin <philippe.houdoin@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 4 Aug 2011 14:35:56 +0200

> You mean just in case create_area() is severely broken? Nothing against 
> defensive programming, but this is overkill.

More probably for the case where copying the Bios image in this area
will failed.

But I agree, the area creation should be done in radeon_hd_getbios()
directly, not in a preemptive way in radeon_hd_init(), using pci's
config rom_size value which could be far larger than needed... or just
set to zero by BIOS, and the actual size been extracted from the rom
header instead.

Other related posts: