[haiku-commits] Re: r42413 - in haiku/trunk/src/add-ons: accelerants/radeon kernel/drivers/graphics/radeon

  • From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Tue, 12 Jul 2011 11:06:33 -0500

On Tue, 12 Jul 2011 17:34:27 +0200, Ingo Weinhold wrote:
Alexander von Gluck wrote:
__INTEL__ is only 32-bit:

http://dev.haiku-os.org/browser/haiku/trunk/build/jam/BuildSetup#L219


I like that the rest of the arch defines are Haiku centric except for
__x86_64__ which is a gcc default on 64-bit Intel platforms

http://dev.haiku-os.org/browser/haiku/trunk/build/jam/BuildSetup#L253

Haiku centric? What does that even mean?


Haiku centric as in "__INTEL__" isn't an established gcc standard define
like __x86__, __x86_64__, __powerpc__, etc

We should probably decide on a standard going forward

We should use what most other platforms use, respectively what gcc
defines by default for the platform, since that will cause the least
surprises for porters.

I am completely fine with that, keep in mind thats is how I did it originally in http://dev.haiku-os.org/changeset/42408 before the __INTEL__ was mentioned to
me.

I'll leave it to someone else to change the BuildSetup though.

  -- Thanks!
      Alex

Other related posts: