[haiku-commits] Re: r42394 - in haiku/trunk: build/jam data/etc src/bin/locale

  • From: Oliver Tappe <zooey@xxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 09 Jul 2011 12:46:33 +0200

Hi Ryan,

thanks for tackling this :-)

On 2011-07-09 at 06:29:21 [+0200], leavengood@xxxxxxxxx wrote:
> Author: leavengood
> Date: 2011-07-09 06:29:20 +0200 (Sat, 09 Jul 2011)
> New Revision: 42394
> Changeset: https://dev.haiku-os.org/changeset/42394
> Ticket: https://dev.haiku-os.org/ticket/7495
> 
> Modified:
>    haiku/trunk/build/jam/HaikuImage
>    haiku/trunk/data/etc/profile
>    haiku/trunk/src/bin/locale/Jamfile
> Log:
> Implement #7495 as per Matt and Ingo's suggestions.
> 
> The various LC_ environment variables (as well as LANG) are set in
> /etc/profile, based on the output of this new simple bin command locale.
> LANG and LC_CTYPE are set based on the first preferred language, whereas the
> formatting variables are all set based on the formatting conventions 
> language.
> 
> The list of LC_ variables are from the locale command on Linux.
> 
> Based on my testing, at least the date command obeys these variables.
> 
[ ... ]
> Modified: haiku/trunk/data/etc/profile
> ===================================================================
> --- haiku/trunk/data/etc/profile    2011-07-08 23:00:38 UTC (rev 42393)
> +++ haiku/trunk/data/etc/profile    2011-07-09 04:29:20 UTC (rev 42394)
> @@ -16,6 +16,21 @@
>  export HISTFILESIZE=50
>  export HISTCONTROL=ignoredups
>  
> +# Locale
> +export LANG=`locale -l`
> +export LC_CTYPE=`locale -c`
> +export LC_TIME=`locale -f`
> +export LC_NUMERIC=$LC_TIME
> +export LC_COLLATE=$LC_TIME
> +export LC_MONETARY=$LC_TIME
> +export LC_MESSAGES=$LC_TIME
> +export LC_PAPER=$LC_TIME
> +export LC_NAME=$LC_TIME
> +export LC_ADDRESS=$LC_TIME
> +export LC_TELEPHONE=$LC_TIME
> +export LC_MEASUREMENT=$LC_TIME
> +export LC_IDENTIFICATION=$LC_TIME

Everything up to (and including) LC_MESSAGES is fine, but LC_PAPER and 
everything following it are glibc extensions which Haiku (our ICU backend) 
doesn't support. So I think those should be dropped again, as it doesn't make 
much sense to set them if they have no actual purpose.

cheers,
        Oliver

Other related posts: