[haiku-commits] Re: r42060 - haiku/trunk/src/add-ons/kernel/drivers/disk/usb/usb_disk
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 08 Jun 2011 22:55:38 +0200
> ----- Ursprüngliche Nachricht -----
> Von: kallisti5@xxxxxxxxxxx
> Gesendet: 08.06.11 21:27 Uhr
> An: haiku-commits@xxxxxxxxxxxxx
> Betreff: [haiku-commits] r42060 -
> haiku/trunk/src/add-ons/kernel/drivers/disk/usb/usb_disk
>
> Author: kallisti5
> Date: 2011-06-08 21:27:39 +0200 (Wed, 08 Jun 2011)
> New Revision: 42060
> Changeset: https://dev.haiku-os.org/changeset/42060
>
> Modified:
> haiku/trunk/src/add-ons/kernel/drivers/disk/usb/usb_disk/usb_disk.cpp
> Log:
> change to non-posix int introduced a small bug, sorry about that
>
> Modified:
> haiku/trunk/src/add-ons/kernel/drivers/disk/usb/usb_disk/usb_disk.cpp
> ===================================================================
> --- haiku/trunk/src/add-ons/kernel/drivers/disk/usb/usb_disk/usb_disk.cpp
> 2011-06-08 18:57:03 UTC (rev 42059)
> +++ haiku/trunk/src/add-ons/kernel/drivers/disk/usb/usb_disk/usb_disk.cpp
> 2011-06-08 19:27:39 UTC (rev 42060)
> @@ -791,7 +791,7 @@
> TRACE("usb lun %d inquiry attempt %d failed\n", i, tries);
>
> uint32 snoozeTime = 1000000 * tries;
> - TRACE("snoozing %u microseconds for usb lun\n", snoozeTime);
> + TRACE("snoozing %lu microseconds for usb lun\n", snoozeTime);
The format macro for uint32 is B_PRIu32 (for uint32_t it's PRIu32). "%lu" is
guaranteed to be broken on 64 bit architectures.
CU, Ingo
Other related posts:
