[haiku-commits] Re: r41520 - in haiku/trunk/build: jam scripts

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 16 May 2011 11:16:43 +0200

On 2011-05-16 at 04:28:43 [+0200], Rene Gollent <anevilyak@xxxxxxxxx> wrote:
> On Sun, May 15, 2011 at 6:45 PM,  <zooey@xxxxxxxxxxxxxxx> wrote:
> > +       . $(HAIKU_TOP)/build/scripts/determine_haiku_revision 
> > $(HAIKU_TOP) \
> > +               $(HAIKU_BUILD_OUTPUT_DIR)
> 
> When invoked this way on FreeBSD, the script fails to execute because
> it thinks it received no arguments. Difference in sh behavior I guess?

Probably. I was already surprised a bit about the sourcing.

> (my shell-fu is unfortunately not the greatest so I'm uncertain as to
> a good platform-independent way to fix this). Also, should the
> executable bit be set on the determine_haiku_revision script? It
> currently isn't.

That isn't necessary, since the script is sourced. But when executing it, 
that will become necessary. Then in the actions the revision needs to be 
extracted from the file, though, and they need to fail when the script 
fails.

CU, Ingo

Other related posts: