[haiku-commits] Re: r41215 - haiku/trunk/src/add-ons/input_server/devices/keyboard

  • From: "Jonas Sundström" <jonas@xxxxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Mon, 11 Apr 2011 20:35:53 +0200

Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> jonas@xxxxxxxxxxx wrote:
> > Log:
> > Add a Quit button to the Team Monitor.
> While it doesn't hurt, isn't that the wrong tool for that job?
> Why not simply use the Deskbar, or even the Switcher?

I've found myself in the Team Monitor on a couple of occassions and
missing a quit option. Sometimes one might want to try quitting
something before killing it, so why not have both options.

We have both quit and kill options in Deskbar and in ProcessController
though kill is a hidden feature in Deskbar.

> What's the use case you are thinking of?

None especially. But having a few perfectly good options does not
necessarily mean an additional one is without value.

Background apps don't have an entry in Deskbar or in the Switcher.

If one has lost the mouse, for whatever reason, Deskbar is somewhat
cumbersome to navigate. (Especially the ProcessController replicant.)

We're probably underusing the Team Monitor since we're so used to
having ProcessController so prominently in Deskbar.

I would like to break out the Team Monitor to a stand-alone app and
merge it with ProcessController. A fullsize version of it. Which the
keyboard input_server add-on would launch on Ctrl-Alt-Delete.
Perhaps also the ActivityMonitor.

> > +TeamListItem::IsApplication()
> > +{
> > +   if (fAppSignature.Length() > 0)
> > +           return true;
> > +   else
> > +           return false;
> > +}
> 1) in these cases, the "else" is superfluous,
> and should be removed to make it clearer.

I would argue that if() return / else return is more beautiful,
or balanced, from an algorithmic point of view. Perhaps it's
a matter of taste.

> 2) in this particular case, it should just be:
>      return fAppSignature.Length() > 0;
> though.

Acknowledged. Will fix.

> Or isn't there an IsEmpty() method as well for BString?

Not yet. I can add it if you like.


Other related posts: