[haiku-commits] Re: r41215 - haiku/trunk/src/add-ons/input_server/devices/keyboard
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 11 Apr 2011 19:44:54 +0200 (MEST)
jonas@xxxxxxxxxxx wrote:
> Log:
> Add a Quit button to the Team Monitor.
While it doesn't hurt, isn't that the wrong tool for that job?
Why not simply use the Deskbar, or even the Switcher? What's the use case you
are thinking of?
> +TeamListItem::IsApplication()
> +{
> + if (fAppSignature.Length() > 0)
> + return true;
> + else
> + return false;
> +}
1) in these cases, the "else" is superfluous, and should be removed to make it
clearer.
2) in this particular case, it should just be:
return fAppSignature.Length() > 0;
though.
Or isn't there an IsEmpty() method as well for BString?
Bye,
Axel.
Other related posts:
