[haiku-commits] Re: r41084 - haiku/trunk/src/kits/support

  • From: Clemens <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 23 Mar 2011 20:55:25 +1300

On Wed, 23 Mar 2011 19:22:21 +1300, Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx> wrote:


Hi Clemens,

Am 22.03.2011 um 21:38 schrieb clemens.zeidler@xxxxxxxxxxxxxx:

Author: czeidler
Date: 2011-03-22 21:38:13 +0100 (Tue, 22 Mar 2011)
New Revision: 41084
Changeset: https://dev.haiku-os.org/changeset/41084

Modified:
  haiku/trunk/src/kits/support/String.cpp
Log:
Switch to iswspace. Fix space detection at the right. Thanks J?\195?\169r?\195?\180me and Ingo. Please review, though.

In order for this to work properly, you have to convert the string from UTF-8 to Unicode (UTF-16?), before a char point can be passed to iswspace as a value of type wint_t.


Hm don't exactly know what this means. Think converting it to UTF-16 is expensive isn't it? So what do you reckon? Why exactly the isspace function can't be used?

thanks,
        Clemens

Other related posts: