[haiku-commits] Re: r41079 - in haiku/trunk/src/add-ons/accelerants/radeon_hd: . AtomBios AtomBios/includes

  • From: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 22 Mar 2011 11:28:36 -0500

On Tue, 22 Mar 2011 16:45:08 +0100
Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:

> > Added:
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/CD_Operations.c
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/Decoder.c
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/hwserv_drv.c
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/
> >   
> > haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/CD_Common_Types.h
> >   
> > haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/CD_Definitions.h
> >   
> > haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/CD_Opcodes.h
> >   
> > haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/CD_Structs.h
> >   
> > haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/CD_binding.h
> >   
> > haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/CD_hw_services.h
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/Decoder.h
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/ObjectID.h
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/atombios.h
> >   haiku/trunk/src/add-ons/accelerants/radeon_hd/AtomBios/includes/regsdef.h
> 
> I think a lowercase directory name would be preferred.

I did it like that because that is the exact same structure as the Xorg
Driver.
(http://cgit.freedesktop.org/xorg/driver/xf86-video-radeonhd/tree/src/AtomBios).

AMD mentions the AtomBios parser may be updated in the future...
however it would be pretty easy to rename the directory.

Also, as an FYI, I am planing on moving the AtomBios includes into the
private radeonhd graphics header directory and setting the AtomBios up
as a static library(.a) to be used by the radeonhd accelerant.


Thoughts?

 -- alex

Other related posts: