[haiku-commits] Re: r41065 - haiku/trunk/src/apps/showimage

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 22 Mar 2011 10:32:20 +0100

On 22.03.2011 00:33, Axel Dörfler wrote:
Work arounds are a bad coding practice, and should only be applied
rarely, and for a good reason.

Sure. My good reason was that I had no time left and didn't know when I would have time next. Unlike you, I don't consider it a good solution to leave things in a broken state so that it's more obvious that something needs fixing. It is interesting to you, me, maybe one more person. Why should the rest of the developers and especially users see something broken and annoying? As seen in the DeskCalc example it may take ages until someone looks at the problem, even when it's obvious, and then still comes up with the wrong "fix". So part of your reasoning is invalid by example.

That's not even talking about the demotivating
effect of such comments. Please consider the implications of your
mail
and how it was supposed to make me feel.

It's criticism, it's not meant to make you feel good :-) Of course I
could have worded it more carefully and nicer, but I consider you being
someone who can take criticism, but maybe I found a bad time.

My point is that your criticism was obvious and IMHO unnecessary all things considered. You specifically pointed out that I wasted my time. In the time it has taken you to take part in this conversion, perhaps you could have looked at the SetToolTip() bug yourself for example. Just ask yourself what would have contributed more to an overall more positive atmosphere. Instead of feeling attacked for a decision I made, I would have felt like "Ah, good to have friends who take care of some stuff I had on my TODO list"...

Best regards,
-Stephan

Other related posts: