[haiku-commits] Re: r41055 - haiku/trunk/src/apps/showimage

  • From: "Stephan Assmus" <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 21 Mar 2011 10:56:27 +0100


Clemens <clemens.zeidler@xxxxxxxxxxxxxx> wrote:
> On Mon, 21 Mar 2011 01:53:38 +1300, <superstippi@xxxxxx> wrote:
> > Author: stippi
> > Date: 2011-03-20 13:53:38 +0100 (Sun, 20 Mar 2011)
> > New Revision: 41055
> > Changeset: https://dev.haiku-os.org/changeset/41055
> > Added:
> >    haiku/trunk/src/apps/showimage/ToolBarView.cpp
> >    haiku/trunk/src/apps/showimage/ToolBarView.h
> > Modified:
> >    haiku/trunk/src/apps/showimage/Jamfile
> >    haiku/trunk/src/apps/showimage/ShowImageWindow.cpp
> >    haiku/trunk/src/apps/showimage/ShowImageWindow.h
> > Log:
> >  * Display a tool bar by default (setting can be toggled in the
> >    View menu)
> Already expressed my toolbar size concerns previously and I think the  
> spacing between the icons is to big / the icons could be a bit smaller.  
> Furthermore, I think it even looks better if the space between the icons  
> is reduced a bit. IMHO the Pe toolbar has a good spacing and icon size.  
> Pe's icons size is (more or less) the default small icon size and should  
> be used everywhere as e.g. deskbar and tracker do. (had the same feeling  
> about the WebPositive toolbar)

Like I said, I don't agree at all. I think the space used is completely a 
non-issue. In Tracker, I want to see as much information as possible in list 
mode, and bigger icons would increase the line-height too much. Still, I think 
the 16x16 icons are so small, for many icons they are not so usable, because 
the contents are barely distinguishable. In a tool bar on the other hand, there 
is only a single line, a few pixels more or less are not important and tackling 
other problems can take priority: 1) The icons can be more distinguishable, 
less blurry. 2) Unlike in Tracker, where there is the whole file name 
contributing to the click target size, the icon is just by itself the click 
target. 16x16 icons like in Pe are not as usable. Of course in a perfect world, 
the whole GUI including the icons would scale with the font-size that the user 
configures. At the same time, I think the 22x22 icons are a good click target 
size for the default font-size in Haiku. So even when I would im
 plement a scalable tool bar size, I would implement the same size as a match 
for the default font size. Maybe I would try 20x20 as well, but below that the 
draw-backs certainly outweight the benefits.

All in all, when I look at ShowImage now, or WebPositive, I don't have any 
issue with the icon size at all, I think the space used by the tool bar is 
completely a non-issue compared to making the icons a usable click target size 
and recognizable.

> Just a small bug: if you leave full screen mode not using the menu the  
> toolbar background is not redrawn (try it with a very small image/
> icon)...

Thanks, will have to see and fix.

> p.s. Again, I'm all for a space efficient combined menu/toolbar solution  
> after R1. Not sure how to make it good looking and consistent, though.  
> Mock-up's are welcome.

I agree that integrating the tool bar functionality into the menu bar may be a 
good idea (BMainMenuBar?). Perhaps an object which combines two individual 
functionalities in an automatic way. I would like to have a BAction or similar 
API, which can be used to manage menu items and tool bar entries via a single 
object representing the action. Future stuff like BTextDocument could export 
BActions which an embedding application can put into the GUI. I think this API 
would need reference counting, and is probably an R2 thing when we make more 
infrastructure and utility classes available to applications.

Best regards,

Other related posts: