[haiku-commits] Re: r40968 - in haiku/trunk/src/apps: activitymonitor bootmanager charactermap codycam deskbar ...

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 16 Mar 2011 12:50:55 +0100

Am 16.03.2011 12:08, schrieb Jonas Sundström:
Ingo Weinhold<ingo_weinhold@xxxxxx>  wrote:

On 2011-03-16 at 09:47:58 [+0100], Stephan Aßmus<superstippi@xxxxxx>  wrote:
Am 16.03.2011 01:42, schrieb jonas@xxxxxxxxxxx:
@@ -686,13 +688,15 @@
   void
   CalcView::AboutRequested()
   {
-    BAlert* alert = new BAlert(B_TRANSLATE("about"),B_TRANSLATE(
-        "DeskCalc v2.1.0\n\n"
-        "written by Timothy Wayper,\nStephan Aßmus and Ingo Weinhold\n\n"
-        B_UTF8_COPYRIGHT "1997, 1998 R3 Software Ltd.\n"
-        B_UTF8_COPYRIGHT "2006-2009 Haiku, Inc.\n\n"
-        "All Rights Reserved."), "OK");
-    alert->Go(NULL);
+    const char* authors[] = {
+        "Timothy Wayper",
+        "nStephan Aßmus",
+        "Ingo Weinhold",
+        NULL
+    };

BTW, of the complete DeskCalc source "svn blame" attributes exactly one
#include line and one blank line to me. The code I have contributed to
(ExpressionParser) has been factored out completely. Should my name be
removed now? Or added to the About windows of all applications using
ExpressionParser?

As already stated recently: IMO none of Haiku's "built-in" apps needs an
About window at all.

I agree. It's mostly vanity, and also a problem to have them reflect the
true authors of the code. If there is reasonable agreement I can start
removing them instead.

A few more voices. Anyone against?

I don't know why it should be so bad to have the authors be mentioned in About windows. I put a lot of effort into apps like MediaPlayer and Icon-O-Matic, why should I not be mentioned? In AboutSystem, this information is lost to the regular user. IMHO it reduces anonymity and makes Haiku feel more approachable on a certain level. Ingo has contributed to the existance of DeskCalc in an important way. Who cares that the code has since been refactored and is available to other apps as well now?

Best regards,
-Stephan

Other related posts: