[haiku-commits] Re: r40870 - haiku/trunk/src/add-ons/kernel/drivers/network/wimax/usb_beceemwmx

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 08 Mar 2011 20:58:15 +0100

Am 08.03.2011 17:56, schrieb Alexander von Gluck:
On Tue, 08 Mar 2011 17:07:00 +0100
Oliver Tappe<zooey@xxxxxxxxxxxxxxx>  wrote:
On 2011-03-08 at 16:27:42 [+0100], kallisti5@xxxxxxxxxxx wrote:
Author: kallisti5
Date: 2011-03-08 16:27:42 +0100 (Tue, 08 Mar 2011)
New Revision: 40870
Changeset: http://dev.haiku-os.org/changeset/40870

[ ... ]
===================================================================
---
haiku/trunk/src/add-ons/kernel/drivers/network/wimax/usb_beceemwmx/Settings.
cpp    2011-03-08 15:27:33 UTC (rev 40869)
+++
haiku/trunk/src/add-ons/kernel/drivers/network/wimax/usb_beceemwmx/Settings.
cpp    2011-03-08 15:27:42 UTC (rev 40870)
@@ -34,7 +34,10 @@
          return;

      int flags = O_WRONLY | O_CREAT | ((gTruncateLogFile) ?
O_TRUNC : 0);
-    close(open(gLogFilePath, flags, 0666));
+    int filehandle = open(gLogFilePath, flags, 0666);
+    if (filehandle>= 0)
+        close(filehandle);
+    }

-------^
This closing brace looks a bit strange, I think. The code either
didn't compile before or it no longer does ...

Thanks for catching that! fixed in r40873... looks like i need more
coffee this morning :)

Always compiling before committing (as a rule) will do... :-)

Best regards,
-Stephan


Other related posts: