[haiku-commits] Re: r40852 - in haiku/trunk/src: apps/deskcalc bin/rc bin/rc/tests
- From: "Jonas Sundström" <jonas@xxxxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Sun, 06 Mar 2011 22:24:56 +0100
Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> jonas@xxxxxxxxxxx wrote:
> > Support added to the resource compiler and resource definition files
> > (.rdef)
> > for application name catalog reference. Please review.
>
> It's been some time since I looked at rc's code, but it looks fine from
> what I can tell.
> I would suggest to add defaults for the catalog entry, btw, so that
> only the catalog entry itself needs to be specified in the usual case.
Are you saying it should exclude the "x-vnd..." app signature part,
in the usual case, and optionally support providing one?
BTW, does it need a unique resource definition ID? (type.def_id?)
...
> > + type.count = 1;
> > + type.def_id = 1;
> > + type.def_name = "SYS:NAME";
>
> You probably mostly copied this, but spacing looks odd, and rc should
> follow our style guide.
Yes, I'll take a look at the file.
/Jonas.
Other related posts:
