Hi Philippe, Philippe Saint-Pierre <stpere@xxxxxxxxx> wrote: > > > + BString label(path.Path()); > > > + _AddItemToPathMenu(path.Path(), > > > label, 3, > > Looks like a bad API decision to use BStrings here. > It seems the reason it's been chosen is to use BView:: > TruncateString() > later. Would it be best to translate it to BString only at this step > or to > use BStrings from the start of the process.. ? Not sure if it's worth fixing, you could check how it's used elsewhere. BTW can't you just pass a const char* there anyway? The implicit BString() constructor should be called in this case which would then look nicer, and the implementation would still benefit from getting a BString already. Bye, Axel.