[haiku-commits] Re: r40762 - haiku/trunk/src/apps/terminal

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 02 Mar 2011 15:23:16 +0100

Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > There is a semantical difference between the two methods, though:
> > RemoveItemAt() returns the item in question (that you don't know
> > before), ie. it passes it over to your responsibility, while
> > RemoveItem() does not, the ownership is kept with the list (if that
> > actually claims ownership).
> One could decide to use RemoveItemAt() just because the method is 
> faster 
> when one already knows the index of the object. I don't think I would 
> prefer adding a deleteIfOwning parameter. I believe the cleanest 
> solution 
> is to just remove the deleteIfOwning parameter from RemoveItem() as 
> well 
> and never delete the item in question (requires all using code to be 
> adjusted). After all the only thing this ugliness saves the caller is 
> an 
> explicit delete.

It would still be nice to have a call that does both, though, I think.

> At any rate, the MakeEmpty() deleteIfOwning parameter makes a lot 
> more 
> sense and I would remove its default value.

Don't forget that BObjectList itself can be configured to either own 
its items or not. I think this is just another source of problems, 


Other related posts: