[haiku-commits] Re: r40630 - haiku/trunk/src/bin/network/netcat

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 24 Feb 2011 13:39:11 +0100

"Jonas Sundström" <jonas@xxxxxxxxxxx> wrote:
> Jérôme Duval Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
> > Thanks for working on this.
> > Though I'm not really pleased with fixing everything found
> > by coverity in imported code.
> > Such a change would have to be merged when updating it, as
> > we don't send this change upstream.
> I thought the gnu packages weren't handled as vendor branches,
> but sort of "ours". I'll steer clear of it.

I think it's perfectly okay to fix bugs in 3rd party code that we are
using, especially when those fixes are done in a way that makes this
possible.
Since strlcpy() is amazingly not part of POSIX, and IIRC also not part
of Linux either, it would not be the solution to apply in portable
code, though; chances of it being accepted upstream are pretty low.

Bye,
   Axel.


Other related posts: