[haiku-commits] Re: r40492 - haiku/trunk/src/servers/net
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 14 Feb 2011 21:39:03 +0100
Philippe Houdoin <philippe.houdoin@xxxxxxxxx> wrote:
> > - fServer.
> > SetAddress(*(in_addr_t*)data);
> > + fServer.SetAddress(
> > +
> > (in_addr_t)B_BENDIAN_TO_HOST_INT32(*(uint32*)data));
> Good catch!
> Sorry for not seeing it while fixing the broadcast issue a few months
> ago.
Hey, stop apologizing for my bugs :-)
> Although, why not using ntohl() macro here?
Because it's the same? Didn't even think of it, but I don't really care
either.
> I noticed that in _ParseOptions() when these network / host byte
> order
> macros are used, they're use with the reverse semantic: hton*() is
> used to convert data from network to host.
> I doesn't change anything on code behavior sure, but semantically the
> nto*() semantic should be use on data coming from network, and hton*()
> on data coming from host.
Feel free to fix it :-))
Bye,
Axel.
Other related posts:
