[haiku-commits] Re: r40457 - haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn
- From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 12 Feb 2011 14:45:37 -0600
On Sat, 2011-02-12 at 10:58 +0100, Stephan Aßmus wrote:
> On 12.02.2011 01:18, kallisti5@xxxxxxxxxxx wrote:
> > Author: kallisti5
> > Date: 2011-02-12 01:18:44 +0100 (Sat, 12 Feb 2011)
> > New Revision: 40457
> > Changeset: http://dev.haiku-os.org/changeset/40457
> >
> > Added:
> >
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/SettingsIfView.cpp
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/SettingsIfView.h
> > Modified:
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/Jamfile
> >
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/SettingsWindow.cpp
> > Log:
> > added BView class to handle drawing IPv4/IPv6 interface configuration
> > options
>
> If that is what is does then "InterfaceConfigurationView" would have
> been a much better name, or simply "ConfigurationView". "SettingsIfView"
> is a horrible name. :-) Naming should be done with someone in mind who
> looks at the code for the first time and tries to find the file that
> most likely implements something he would like to mess with. This could
> be yourself in a couple of month of not looking at the code. ;-)
Lol, for what it's worth... I lamented over that class/file name for
about 15 minutes.
Any ideas what it should be renamed to?
Here is whats there so far:
InterfacesAddOn -- base add-on
InterfacesListView -- BListView/BListItem of interfaces
NetworkSettings -- class that reads/sets interface network params
SettingsWindow -- Window for interface settings
SettingsHwView -- tab view for hardware interface settings. (future)
SettingsIfView -- tab view for IP settings (IPv4 or IPv6)
Maybe SettingsIPView or SettingsAddrView instead? ( SettingsIPView this
was my first choice.. but i thought it looked weird )
I could go with InterfaceConfWindow (vs SettingsWindow),
InterfaceConfAddrView, and InterfaceConfHwView but the class names are
getting a little long.
Thanks!
-- Alex
Other related posts:
